Move http:// to https:// for (mostly) external references #77
Conversation
| @@ -20,7 +20,7 @@ In the above example the namespace `pc` (port compiler) has a provider named `co | |||
|
|
|||
| We'll implement an example provider that "compiles" files in the directory `exc_files/` with the extension `.exc` to the priv directory of the application. The full source code can be found on [github](https://github.com/tsloughter/rebar3_ex_compiler). | |||
|
|
|||
| The definitions are similar to what was done in the [Building Plugins](http://www.rebar3.org/docs/plugins) tutorial, but in this case we also have a `NAMESPACE` macro. This is important because the provider name is `compile` which, without defining a new namespace, would conflict with the existing `default` namespace `compile` provider. | |||
| The definitions are similar to what was done in the [Building Plugins](https://www.rebar3.org/docs/configuration/plugins/) tutorial, but in this case we also have a `NAMESPACE` macro. This is important because the provider name is `compile` which, without defining a new namespace, would conflict with the existing `default` namespace `compile` provider. | |||
There was a problem hiding this comment.
Link was broken.
| @@ -25,7 +25,7 @@ $ rebar3 new cmake | |||
| ===> Writing c_src/Makefile | |||
| ``` | |||
|
|
|||
| In `test_nif`'s `rebar.config`, add the [pre_hooks](http://www.rebar3.org/v3.0/docs/configuration#hooks) line so that `make` is called when `compile` is run. Furthermore, add the `post_hooks` entry for cleaning up the built C object files. | |||
| In `test_nif`'s `rebar.config`, add the [pre_hooks](https://www.rebar3.org/docs/configuration/configuration/#hooks) line so that `make` is called when `compile` is run. Furthermore, add the `post_hooks` entry for cleaning up the built C object files. | |||
There was a problem hiding this comment.
Link was broken.
|
I wonder if references to rebar3.org could simple do without the prefix and go |
|
|
||
| ## Escript | ||
|
|
||
| Full details at the [escriptize command](http://www.rebar3.org/docs/commands#escriptize). Example configuration values below. | ||
| Full details at the [escriptize command](https://www.rebar3.org/docs/commands#escriptize). Example configuration values below. |
There was a problem hiding this comment.
we should actually use relative paths here I think since it's a local URL.
There was a problem hiding this comment.
Yup. I'll move all of them, while I'm at it.
There was a problem hiding this comment.
Hm... actually some, while not broken, are pointing to a "parent" page, as per redirection rules, it seems. Will fix some more.
There was a problem hiding this comment.
All this is now done.
| @@ -25,7 +25,7 @@ $ rebar3 new cmake | |||
| ===> Writing c_src/Makefile | |||
| ``` | |||
|
|
|||
| In `test_nif`'s `rebar.config`, add the [pre_hooks](http://www.rebar3.org/v3.0/docs/configuration#hooks) line so that `make` is called when `compile` is run. Furthermore, add the `post_hooks` entry for cleaning up the built C object files. | |||
| In `test_nif`'s `rebar.config`, add the [pre_hooks](https://www.rebar3.org/docs/configuration/configuration/#hooks) line so that `make` is called when `compile` is run. Furthermore, add the `post_hooks` entry for cleaning up the built C object files. | |||
| @@ -90,7 +90,7 @@ This configuration will allow to call `rebar3 check`, which will run the followi | |||
| - `xref` analysis for dead code and calls to functions that don't exist | |||
| - `dialyzer` checks for inconsistencies and type errors | |||
| - build the project documentation, to make sure it can do so without errors | |||
| - run regression tests in `proper` (using [the PropEr plugin](https://www.rebar3.org/docs/using-available-plugins#section-proper)) | |||
| - run regression tests in `proper` (using [the PropEr plugin](/docs/configuration/plugins/#proper)) | |||
There was a problem hiding this comment.
Wasn't broken, but was "no good".
|
Hm... let me run a tool here, to see what else can be found. |
|
Hm...
|
|
@ferd, given #77 (comment), do you think there's anything prevent this from being merge? |
|
Ah... 😄 But there's still:
|
|
The basho mailing list is still "active" and monitored. We'll eventually need to change freenode links to libera as well. I assumed the hosting.review thing was solved in a comment because I didn't see it in the changelog rather than assuming it was left otherwise. Let me take a look. |
I saw I was getting redirected from https://rebar3.org (when clicking an external link) to a non-secure page.
I'm not sure using HTTP instead of HTTPS is done on purpose, but I guess it won't hurt, too much, to use HTTPS, where available (the "too much" part is important, since browsers will usually warn you if security is broken or compromised).
All individual links tested, which even resulted in some fixes to broken links (I'll point these out, in case the PR doesn't get accepted in this form, but link fixing is still up).
Notes: